-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user movie reviews #388
Comments
I think we should use summernote to do this. It's very flexible, so we can just remove the unnecessary things such as tables, images, videos, etc. and only keep the basics like bold, italic, underlined, bullet list, and maybe different font styles (but idk about that one). It also saves us a lot of time trying to figure out how to make a custom input with javascript stuff. Trust me, I have tried to make this without libraries like Summernote, and it's hell. Though this is a concern of mine, so maybe we can use regex to prevent XSS vulnerabilities. |
What do you think about the character limit? And what kind of database column should the review be stored in? |
isn't the written review capability sort of achieved by the comment feature? it just needs to be reworked in term of design to be suitable for longer texts instead of short comments. imo something like summernote is kind of overkill, i think this could be achieved without using 3rd party applications that involve styling like lists, bold, italic, etc. as that's not very important when writing a review for a movie, especially when you weigh the benefit of being able to use extra styling options against the cost of using a third party application that makes it all more complicated than it needs to be (think about exporting the reviews) |
I see a difference between a comment and a review. A comment is more of a generic note, I use comments for example to keep track of which movies I saw in the cinema (and which one), a review on the other hand is much more specific. I agree that we probably do not need a feature rich text editor for reviews. |
ah i see, then i agree that it makes sense to add a review option altogether, something like another option for a watch date alongside Date, Comment, and Plays, as that would allow people to have different reviews for different watch dates. |
Users should be able to write and share reviews with others.
TODO
The text was updated successfully, but these errors were encountered: