Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow success on reaching maxiter #156

Closed
jchodera opened this issue Jul 8, 2023 · 2 comments
Closed

Add option to allow success on reaching maxiter #156

jchodera opened this issue Jul 8, 2023 · 2 comments

Comments

@jchodera
Copy link

jchodera commented Jul 8, 2023

For some QCFractal OptimizationDataset workflows, it would be very useful to take at most K optimization steps and still return successful completion. For example, when starting from snapshots sampled from an MM surrogate potential at 300K, the initial QM energies may be too high, but a few steps of optimization is sufficient to explore the thermodynamically relevant energy surface in the vicinity of the starting geometry.

QCFractal / QCEngine appears to call geomeTRIC in a manner that passes in a JSON document via run_json. Options such as whether to use tric or cart appear to be passed this way. If an option such as success_on_maxiter could be passed to signal that reaching maxiter should still successfully return completion of the optimization trajectory, this use case could easily be supported.

@leeping
Copy link
Owner

leeping commented Sep 10, 2023

This has been implemented and merged into master now. It should be part of release v1.1. Thanks for your patience. :)

@leeping leeping closed this as completed Sep 10, 2023
@jchodera
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants