New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermediate files added to .gitignore #43
Conversation
This looks good, btw. I just need to test out the 64-bit build, which is also a welcome addition. |
@leethomason You mean like generally? or to test this pull request? Cuz I builds fine in 64 bit right now. (Linux, Mac and Windows). :) |
I mean i like the changes. But i do want to verify on my machine. Just
|
2 problems with the pull request:
|
Which Visual Studio edition you use? |
2010 On Wed, Jul 25, 2012 at 10:00 AM, Arkadiy Shapkin
|
Express, Professional, Ultimate? |
Sorry - 2010 Express. The free one. (I use the fancy one at work, and On Wed, Jul 25, 2012 at 10:09 AM, Arkadiy Shapkin
|
VS 2010 Express doesn't support 64-bit projects |
Of all the silly things. Go Microsoft. Hmmm...the critical issue then is the CreateDirectory(). How do you lee On Wed, Jul 25, 2012 at 10:18 AM, Arkadiy Shapkin
|
I'll fix this later. Replace it by mkdir |
Well...that introduces a new dependency. You end up with: #if MSCV The maintenance of that strikes me as more problematic than the lack How about this approach:
lee On Wed, Jul 25, 2012 at 10:21 AM, Arkadiy Shapkin
|
mkdir is standard C function. Should work on all platforms. |
Live and learn...I thought it was only in the *nix flavors: http://www.cplusplus.com/reference/clibrary/cstdio/ But VS2010 does support it, admittedly in their own special way: http://msdn.microsoft.com/en-us/library/2fkk4dzw.aspx lee On Wed, Jul 25, 2012 at 11:02 AM, Arkadiy Shapkin
|
but standard mkdir works too http://msdn.microsoft.com/en-us/library/ms235326%28v=vs.80%29.aspx ef1c69c |
I should warn you guys, I've heard rumors all the posix C calls will go away (if not the whole C API), at least the SUA will: http://brianreiter.org/2011/09/15/sua-deprecated-in-windows-8/ That means all the following calls will go away in W8: http://technet.microsoft.com/en-us/library/cc776816(v=ws.10) (which include most of the _* ones., like _mkdir and mkdir <= VS2008) I really hope I'm mistaken, windows is a pretty big market for my game stuff. |
@gamaral We use C API only in test application |
Agreed, only the test. However, mkdir() is still different on *nix and Windows: http://pubs.opengroup.org/onlinepubs/007904875/functions/mkdir.html I'll put in the fix. lee On Wed, Jul 25, 2012 at 12:13 PM, Arkadiy Shapkin
|
No description provided.