Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate files added to .gitignore #43

Merged
merged 2 commits into from Jul 25, 2012

Conversation

KindDragon
Copy link
Contributor

No description provided.

@leethomason
Copy link
Owner

This looks good, btw. I just need to test out the 64-bit build, which is also a welcome addition.

@gamaral
Copy link
Contributor

gamaral commented Jul 25, 2012

@leethomason You mean like generally? or to test this pull request? Cuz I builds fine in 64 bit right now. (Linux, Mac and Windows). :)

@leethomason
Copy link
Owner

I mean i like the changes. But i do want to verify on my machine. Just
haven't had the time yet.
On Jul 24, 2012 7:25 PM, "Guillermo A. Amaral" <
reply@reply.github.com>
wrote:

@leethomason You mean like generally? or to test this pull request? Cuz I
builds fine in 64 bit right now. (Linux, Mac and Windows). :)


Reply to this email directly or view it on GitHub:
#43 (comment)

@leethomason
Copy link
Owner

2 problems with the pull request:

  • CreateDirectory() is windows-only. I'm not aware of a cross-platform way to create a directory.
  • When I compile x64, I get: Error: The "ConfigurationGeneral" rule is missing from the project.

@KindDragon
Copy link
Contributor Author

When I compile x64, I get: Error: The "ConfigurationGeneral" rule is missing from the project.

Which Visual Studio edition you use?

@leethomason
Copy link
Owner

2010

On Wed, Jul 25, 2012 at 10:00 AM, Arkadiy Shapkin
reply@reply.github.com
wrote:

When I compile x64, I get: Error: The "ConfigurationGeneral" rule is missing from the project.

Which Visual Studio edition you use?


Reply to this email directly or view it on GitHub:
#43 (comment)

@KindDragon
Copy link
Contributor Author

Express, Professional, Ultimate?

@leethomason
Copy link
Owner

Sorry - 2010 Express. The free one. (I use the fancy one at work, and
have never noticed a difference.)
lee

On Wed, Jul 25, 2012 at 10:09 AM, Arkadiy Shapkin
reply@reply.github.com
wrote:

Express, Professional, Ultimate?


Reply to this email directly or view it on GitHub:
#43 (comment)

@KindDragon
Copy link
Contributor Author

VS 2010 Express doesn't support 64-bit projects

@leethomason
Copy link
Owner

Of all the silly things. Go Microsoft.

Hmmm...the critical issue then is the CreateDirectory(). How do you
feel about pulling out that (and the 'out' files, regrettably), and
then I can at least merge in the x64 changes?

lee

On Wed, Jul 25, 2012 at 10:18 AM, Arkadiy Shapkin
reply@reply.github.com
wrote:

VS 2010 Express doesn't support 64-bit projects


Reply to this email directly or view it on GitHub:
#43 (comment)

@KindDragon
Copy link
Contributor Author

I'll fix this later. Replace it by mkdir

@leethomason
Copy link
Owner

Well...that introduces a new dependency. You end up with:

#if MSCV
CreateDirectory()
#elif
mkdir
#elif
???
#endif

The maintenance of that strikes me as more problematic than the lack
of 'out' directory.

How about this approach:

  • put some text file, in source control, in the output directory.
    (readme.txt contains a brief message that this is where output is
    written.)
  • then you are guaranteed the existence of the directory, and don't
    need the Create/mk

lee

On Wed, Jul 25, 2012 at 10:21 AM, Arkadiy Shapkin
reply@reply.github.com
wrote:

I'll fix this later. Replace it by mkdir


Reply to this email directly or view it on GitHub:
#43 (comment)

@KindDragon
Copy link
Contributor Author

mkdir is standard C function. Should work on all platforms.

@leethomason
Copy link
Owner

Live and learn...I thought it was only in the *nix flavors:

http://www.cplusplus.com/reference/clibrary/cstdio/

But VS2010 does support it, admittedly in their own special way:

http://msdn.microsoft.com/en-us/library/2fkk4dzw.aspx

lee

On Wed, Jul 25, 2012 at 11:02 AM, Arkadiy Shapkin
reply@reply.github.com
wrote:

mkdir is standard C function. Should work on all platforms.


Reply to this email directly or view it on GitHub:
#43 (comment)

@KindDragon
Copy link
Contributor Author

@gamaral
Copy link
Contributor

gamaral commented Jul 25, 2012

I should warn you guys, I've heard rumors all the posix C calls will go away (if not the whole C API), at least the SUA will:

http://brianreiter.org/2011/09/15/sua-deprecated-in-windows-8/

That means all the following calls will go away in W8:

http://technet.microsoft.com/en-us/library/cc776816(v=ws.10) (which include most of the _* ones., like _mkdir and mkdir <= VS2008)

I really hope I'm mistaken, windows is a pretty big market for my game stuff.

@KindDragon
Copy link
Contributor Author

@gamaral We use C API only in test application

@leethomason
Copy link
Owner

Agreed, only the test. However, mkdir() is still different on *nix and Windows:

http://pubs.opengroup.org/onlinepubs/007904875/functions/mkdir.html

I'll put in the fix.

lee

On Wed, Jul 25, 2012 at 12:13 PM, Arkadiy Shapkin
reply@reply.github.com
wrote:

@gamaral We use C API only in test application


Reply to this email directly or view it on GitHub:
#43 (comment)

@leethomason leethomason merged commit ef1c69c into leethomason:master Jul 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants