Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: showLineNumber #35

Closed
runyasak opened this issue Jul 22, 2019 · 8 comments
Closed

Feature Request: showLineNumber #35

runyasak opened this issue Jul 22, 2019 · 8 comments
Labels

Comments

@runyasak
Copy link

Hi, I always use vue-json-pretty component to render beautiful JSON data.

In my opinion, it should show line number of JSON data as option.
Is it interesting or useful? Please, let me know your ideas and comments.

Thank you,
World

@leezng
Copy link
Owner

leezng commented Jul 23, 2019

image

Like this? I think it can be an option.

@runyasak
Copy link
Author

@leezng
Yes, like that.
It would be great if it is an option and can change colour.

Actually, you can assign me to do this issue. 😂

@leezng
Copy link
Owner

leezng commented Jul 25, 2019

@runyasak
If you can help me to do this issue, you're welcome to do. Maybe showing the numbers is more important, the color can be deferred.

@runyasak
Copy link
Author

Thanks @leezng,

I will come up with PR later.
Please, do not forget to review my PR. 😁

@runyasak
Copy link
Author

runyasak commented Oct 30, 2019

Hi, @leezng sorry for waiting.

I have created PR but didn't finish, need some review & advice.
Please, review on this PR. #48

@jakubstankowski
Copy link

Hi!

Any news about show line number feature ?
It will be great option

@leezng
Copy link
Owner

leezng commented Apr 10, 2020

There are some unsolved problems, such as how to calculate those unexpanded

@runyasak
Copy link
Author

runyasak commented Apr 12, 2020

Hi, long time no see.

I have tried to develop.
However, I have stuck with components recursive, as you can see from my PR #48 .

If you have any feedback or solution, please give me some advice or suggestion.
I will make it work as fast as I can. 😎

@leezng leezng added this to the 2.0 milestone Oct 17, 2020
@leezng leezng removed this from the 2.0 milestone Dec 13, 2020
@leezng leezng closed this as completed in 4a5b934 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants