Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password reset email should be configurable #35

Open
SLaks opened this issue May 6, 2013 · 2 comments
Open

Password reset email should be configurable #35

SLaks opened this issue May 6, 2013 · 2 comments

Comments

@SLaks
Copy link

SLaks commented May 6, 2013

https://github.com/lefnire/derby-auth/blob/master/index.js#L316-L322

HabitRPG shouldn't be hard-coded anywhere in this library.

Some other issues:

  • The username and new password should be HTML-escaped
  • This allows attackers to bother users by resetting their passwords every 5 minutes; you should have some kind of verification before resetting (or, better yet, a single-use expiring link in the email that lets the user enter a new password)
@SLaks
Copy link
Author

SLaks commented May 6, 2013

I'm not using derby-auth at all; these are just issues that ought to be fixed.

@lefnire
Copy link
Owner

lefnire commented May 13, 2013

noted, marking up to important. Thank SLaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants