You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's also an advantage of having the extra space, it makes the log file grammar a bit less ambiguous to parse, because the 's is never part of an interesting token and serves as a separator.
eg Earthbind Totem 's Earthbind was evaded by Anvilrage Footman.
when you see the " 's " you know the npc/player name has ended.
while with Earthbind Totem's Earthbind was evaded by Anvilrage Footman.
it's not obvious what Earthbind Totem's Earthbind is, because ' is allowed inside npc names. Harder to tell when the npc name ends and spell name starts. You need context or lookahead/lookbehind lookups or multiple passes over the line to parse it all and then to remove the optional trailing 's from names.
Interesting find! As each upload is parsed during upload the damage is done but we should definately look into the logger for future use and less breaking of other add-ons. Tbc
A quick ctrl+f search in https://github.com/YamaYAML/LegacyPlayersV4/blob/45bcf125bf623404721d6420089c397ff0088d69/Addons/AdvancedVanillaCombatLog/core.lua#L567C45-L567C45
shows 84 instances of a space being placed between unit name and the " 's "
This breaks a lot of addons that need to read events from combat log. Example: Bigwigs
The text was updated successfully, but these errors were encountered: