Refactor const params #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbkaisetsu
reviewed
Nov 9, 2021
Co-authored-by: Koichi Akabe <vbkaisetsu@gmail.com>
Co-authored-by: Koichi Akabe <vbkaisetsu@gmail.com>
|
Thank you for your suggestions! |
vbkaisetsu
added a commit
that referenced
this pull request
Dec 15, 2021
* Add detailed description * add * add * add document * Update src/lib.rs Co-authored-by: Koichi Akabe <vbkaisetsu@gmail.com> * Update src/lib.rs Co-authored-by: Koichi Akabe <vbkaisetsu@gmail.com> * Update src/lib.rs Co-authored-by: Koichi Akabe <vbkaisetsu@gmail.com> * minor * update with lib.rs * enhance * insert line break Co-authored-by: Koichi Akabe <vbkaisetsu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved constant parameters used only in
builder.rsto the file. And,FAIL_INVALIDis replaced intoFAIL_MAXbecause a default fail value can be set to zero and the constant parameter will be used only for indicating the maximum possible value.