Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some functions following API guidelines #77

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Rename some functions following API guidelines #77

merged 1 commit into from
Jul 13, 2022

Conversation

vbkaisetsu
Copy link
Member

This branch renames some functions as follows:

  • Removes the prefix get_.
  • Removes the prefix set_ from zero-cost functions, adds the suffix _mut, and changes to return the mutable reference.

For some structures, leave set_ for consistency.

@vbkaisetsu vbkaisetsu changed the title Follow API guidelines Rename some functions following API guidelines Jul 13, 2022
@vbkaisetsu vbkaisetsu marked this pull request as ready for review July 13, 2022 03:34
@vbkaisetsu vbkaisetsu merged commit 5601ce7 into main Jul 13, 2022
@vbkaisetsu vbkaisetsu deleted the follow-api-guidelines branch July 13, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kg86 kg86 kg86 approved these changes

@kampersanda kampersanda kampersanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbkaisetsu @kg86 @kampersanda