Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring events not shown? #1

Closed
unhammer opened this issue Dec 2, 2020 · 3 comments
Closed

Recurring events not shown? #1

unhammer opened this issue Dec 2, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@unhammer
Copy link

unhammer commented Dec 2, 2020

Related: alphapapa/org-ql#159

@legalnonsense
Copy link
Owner

legalnonsense commented Dec 2, 2020

Should be fixed in the repeat branch.

Added org-ql predicate to look for repeated times.

(org-ql--defpred ts-repeat ()

Added loop to update repeated times to current using ts.el:

(defun org-timed-alerts--update-repeated-event (timestamp-string)

Added a check to the parser to call the update function if the timestamp has a repeat:

(if (org-get-repeat time)

Easier to to it this way than to find the built-in agenda functions that do this.

Have not tested much but seems to be working.

@unhammer
Copy link
Author

unhammer commented Dec 2, 2020

Easier to to it this way than to find the built-in agenda functions that do this.

I did it the hard way by trying to understand org-agenda.el, I wonder which one of us wasted the least time =P ((org-time-string-to-absolute org-ts-string from-day 'future) gives the first absolute day on or after from-day, c.f. usage here)

@legalnonsense
Copy link
Owner

legalnonsense commented Dec 2, 2020

Yours is definitely cleaner! Seems like my hackier solution is working, so will keep it until the urge to clean it up arises. Totally forgot about repeat events when I wrote this so thank you for pointing it out. Think it's all working now but keeping this open until I confirm. Your upcoming event package looks good. Also been using org-mru-clock for a long time now.

@legalnonsense legalnonsense added the enhancement New feature or request label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants