Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend zero to VectorOfVectors.cumulative_length #45

Open
gipert opened this issue Dec 1, 2023 · 1 comment
Open

Prepend zero to VectorOfVectors.cumulative_length #45

gipert opened this issue Dec 1, 2023 · 1 comment
Labels
enhancement New feature or request performance Code performance types LGDO types

Comments

@gipert
Copy link
Member

gipert commented Dec 1, 2023

This would allow us to view VectorOfVectors as an Awkward array with no memory re-allocation. We obviously still need to strip it out or add it when writing/reading to LH5.
@gipert gipert added enhancement New feature or request performance Code performance types LGDO types labels Dec 1, 2023
@gipert
Copy link
Member Author

gipert commented Dec 2, 2023

This will unfortunately require an API change: the cumulative_length argument of VectorOfVectors.__init__() must always start with 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance Code performance types LGDO types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gipert