Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setTransform api in class ElementCore #66

Closed
TyrealGray opened this issue Dec 20, 2017 · 1 comment
Closed

add setTransform api in class ElementCore #66

TyrealGray opened this issue Dec 20, 2017 · 1 comment
Assignees
@TyrealGray
Labels
enhancement epic feature help wanted nwjs pixijs
Projects
Alpha

Comments

@TyrealGray
Copy link
Member

Right now class Terrain only have one container, and the position x & y are being set directly.

I am afraid of stack overflow because the map is unlimited and the number will not be accurate somehow.

So the solution could be:

  1. add setTransform api in class ElementCore, and specialize class Terrain's api setTransform.
  2. setTransform receives vector as param, and class LayerAgent's api moveLayerTo does not set position directly anymore.
  3. Terrain's container position does not change anymore, and more container will be inside Terrain's container dynamically .
  4. each container will render a new branch of Hexagon on the fly when layer is moving to certain coordinates
@TyrealGray TyrealGray self-assigned this Dec 20, 2017
@TyrealGray TyrealGray added this to In Progress in Alpha Dec 20, 2017
@TyrealGray TyrealGray removed their assignment Dec 20, 2017
TyrealGray pushed a commit that referenced this issue Jan 20, 2018
refactor class Terrain, add class HexagonRegion #66
fc02f81
TyrealGray pushed a commit that referenced this issue Jan 24, 2018
finished setTransform api #66
30d2c7f 
optimize terrain render and hexagon render recycle feature #40
change dispose api parameter, add option for not dispose texture
@TyrealGray TyrealGray self-assigned this Jan 24, 2018
@TyrealGray
Copy link
Member Author

finished in 30d2c7f

Alpha automation moved this from In Progress to Done Jan 24, 2018
TyrealGray pushed a commit that referenced this issue Jan 6, 2021
refactor class Terrain, add class HexagonRegion #66
ced2970 
Former-commit-id: fc02f81
TyrealGray pushed a commit that referenced this issue Jan 6, 2021
finished setTransform api #66
67a5a79 
optimize terrain render and hexagon render recycle feature #40
change dispose api parameter, add option for not dispose texture


Former-commit-id: 30d2c7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TyrealGray TyrealGray

Labels
enhancement epic feature help wanted nwjs pixijs
Projects
Alpha
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TyrealGray