Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of Missing Features #18

Closed
9 tasks
leggettc18 opened this issue Jun 7, 2019 · 1 comment
Closed
9 tasks

List of Missing Features #18

leggettc18 opened this issue Jun 7, 2019 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request suggestion
Milestone

Comments

@leggettc18
Copy link
Owner

In GitLab by @leggettc18 on Oct 7, 2018, 18:19

The following is a list of features not yet implemented that I think should be implemented for this project to be worth publishing.

  • Implement IntoIterator on FundManager
  • Implement FromIterator on FundManager

These two may allow for simplification of the save and load functions.

  • Implement a feature to set the goal or amount of a fund to a specific value after creation
  • Adding more code examples to the documentation
  • Fine tune error handling, creating a few custom Error types if necessary.
  • Implementing Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Debug, Display, Default traits on Fund and FundManager where applicable.

These are other things worth considering, which are not strictly necessary right away, and may require some investigation into their usefulness what Rust's best practices are

  • Having functions like print_all from the library crate return strings to the caller instead of printing to stdout
  • Having separate functions for getting funds, one that gets a mutable reference, one that gets an immutable one, and perhaps some unsafe getter methods that don't check for errors first.
  • Implementing a feature where each fund gets a certain percentage when a deposit happens that isn't delegated to a specific Fund (not sure if this should happen before 1.0.0 or come after in a 1.1.0 release).

This list may fluctuate if I think of anything else. I got some of these additions from things I've noticed while doing other fixes and enhancements, and some of them came from here.

@leggettc18 leggettc18 added this to the 1.0.0 milestone Jun 7, 2019
@leggettc18 leggettc18 self-assigned this Jun 7, 2019
@leggettc18 leggettc18 added documentation Improvements or additions to documentation enhancement New feature or request suggestion labels Jun 7, 2019
@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Oct 7, 2018, 18:25

closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request suggestion
Projects
None yet
Development

No branches or pull requests

1 participant