Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load function panics on a parser error #8

Closed
leggettc18 opened this issue Jun 7, 2019 · 7 comments
Closed

Load function panics on a parser error #8

leggettc18 opened this issue Jun 7, 2019 · 7 comments
Assignees
@leggettc18
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@leggettc18
Copy link
Owner

In GitLab by @leggettc18 on Sep 27, 2018, 18:19

/u/usernamedottxt on Reddit said

Your load function unwraps and panics on a parser error. Should return a result instead.

https://www.reddit.com/r/rust/comments/9jdjpc/my_new_project_in_rust_open_to_critiques_and/e6qno3f
@leggettc18 leggettc18 added this to the 1.0.0 milestone Jun 7, 2019
@leggettc18 leggettc18 self-assigned this Jun 7, 2019
@leggettc18 leggettc18 added the bug Something isn't working label Jun 7, 2019
@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Sep 27, 2018, 18:22

changed the description

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Sep 27, 2018, 20:16

mentioned in commit f4ddd96

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Sep 27, 2018, 20:30

mentioned in merge request !1

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Sep 27, 2018, 20:55

mentioned in commit b45918f

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Sep 27, 2018, 21:07

mentioned in commit 32666b8

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Sep 27, 2018, 21:15

closed via merge request !1

@leggettc18
Copy link
Owner Author

In GitLab by @leggettc18 on Sep 27, 2018, 21:15

mentioned in commit e3c8591

@leggettc18 leggettc18 mentioned this issue Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leggettc18 leggettc18

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@leggettc18