Two funds can have the same name, rendering one or the other inaccessible

[leggettc18]

In GitLab by @leggettc18 on Sep 28, 2018, 20:43

I didn't add any way to make sure fund names are unique upon creation, so two funds with the same name can be added. The get_by_name function returns only one, whichever one it finds first, rendering one or the other inaccessible depending on how the Fund Vector is sorted. Implementing PartialEq on Fund would allow to check if a fund by the name already exists in the Fund Vector before adding it, and the Fund::new() function can return an error if it does.

[leggettc18]

In GitLab by @leggettc18 on Sep 28, 2018, 20:49

I just realized Fund::new() has no way of checking the Fund Vector. Perhaps the best way to fix this is to create a sort of FundManager struct that holds the Fund Vector and abstracts some of Fund's functionality.

[leggettc18]

In GitLab by @leggettc18 on Sep 28, 2018, 23:32

mentioned in commit e656b84

[leggettc18]

In GitLab by @leggettc18 on Sep 28, 2018, 23:32

mentioned in commit 81bb656

[leggettc18]

In GitLab by @leggettc18 on Sep 28, 2018, 23:32

mentioned in commit f643499

[leggettc18]

In GitLab by @leggettc18 on Sep 28, 2018, 23:46

closed