-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The starcraft script isn't working as intended. #168
Comments
Hello, thank you for your report. |
I just optimized code in clean.sh script and fixed a bug than can cause your issues, tell me if you can still reproduce them. |
That was impressively fast, thank you! The issue was probably caused by me installing to a different directory than the default, I didn't think that would matter. Can I suggest changes to the script to support that (installing to any directory)? To detect the game directory, you can find the StarCraft.exe and strip that out of the string:
Then to create the symbolic links you can strip off the drive_c/ prefix:
This should make it easier to unpack the cnc-ddraw, since I'd be happy to make a pull request if that's ok? Please let me know if I'm being too much. It's weekend after all. Debug output showing script not finding where i installed the game:
|
you broke an important Lutris script rule: always let the default options unchanged during install ;)
When we write Lutris script installer, we should prioritizing Lutris code usage and minimize bash code usage. If game installs correctly for you now, can we close this issue? |
I tested and it works, feel free to close this. Just a little question, about the comment the Is there a starcraft cd version which doesn't pick this one, and this is to work around that? |
yes, one Starcraft cd version installs his files to "program files" instead of "program files (x86)", so my script creates a symbolik link between this two folders. |
This line moved everything in my $HOME/tmp folder to the root of the wineprefix:
MyLittleLutrisScripts/Starcraft/clean.sh
Line 36 in b169d20
The preceding
find
command copied install.exe to the root of the wineprefix instead of the game directory.The text was updated successfully, but these errors were encountered: