Decompiling with --obfuscationpath does not create local variable names using deobfuscated name

[Marcono1234]

CFR version

0.147

Description

When decompiling with the newly introduced --obfuscationpath option, local variables names are not generated based on the deobfuscated name. E.g. if a class MyClass is obfuscated to a, then a local variable of type MyClass will be named a1 instead of myClass.

public class MyClass {
    public void doSomething(OtherClass b2, String string) {
        OtherClass b3 = new OtherClass();
        if (b2 != null) {
            b3 = b2;
        }
        b3.toString();
    }
}

Reproduction steps

1. Download
   • var-name-obf.jar.zip (remove .zip, this is only to make GitHub happy)
   • mappings.txt
2. Run CFR

   java -jar ./cfr-0.147.jar var-name-obf.jar --obfuscationpath mappings.txt
   

[leibnitz27]

This one is unlikely to change in the near future. The obfuscation rewriter is implemented as a display layer (rather than an explicit rewrite), as all resolution etc needs to use obfuscated names.

As such, local variable names have been assigned by this point - and sufficient context isn't available in the display layer to rewrite these.