Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotate when use labelsFilter #13

Closed
Huxpro opened this issue Aug 11, 2015 · 1 comment
Closed

Fix rotate when use labelsFilter #13

Huxpro opened this issue Aug 11, 2015 · 1 comment

Comments

@Huxpro
Copy link

Huxpro commented Aug 11, 2015

the rotation of labels is calculated with all label length,
can you make the rotation depends on the label length after filter?

@leighquince
Copy link
Owner

hey sorry for the late reply. I had tried this when i was first developing the filter and when there is a lot of data I found that without rotation the label covered several datapoints (in all of my use cases for creating it the reason a filter is there is because they can't all fit in so most of the time there is a lot of data on the graph). With this overlap it became hard to distinguish the original datapoint the label was trying to show. With the rotation this is obvious because the label ends at the point where the data is on the graph. Because of that i decided against re adjusting the rotation after the filter was applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants