Add median to iterable_num #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a median function to iterable_num. I also reformatted the zero argument functions to getters (which improves readability IMO). I also updated the documentation of average to reflect the actual function.
|
Whoops, didn't realize that the tests were based around the current, non-getter API. Will fix and re-pull... |
AKushWarrior
changed the title
|
Median seems like a logical accompaniment to mean, and has a use-case. In a similar vein, mode might also be included. However, the mode use-case is too niche for this package, I think. Also, I noticed that the average documentation was a bit inaccurate, so I cleaned it up... |
|
I'm fine with adding |
|
@passsy median tests and null handling have been added. Waiting for review... |
|
Thanks for your contribution. is |
|
Haha, we'll see. In all seriousness, I might make a PR with some more basic stats (mode, std dev, variance?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a median function to iterable_num.
I also reformatted the zero argument functions to getters (which improves readability IMO). I also updated the documentation of average to reflect the actual function.
EDIT: probably shouldn't have changed to getters; it's pretty useless and might break code unnecessarily. Will update PR...