WIP: Migrate to nnbd #120
Merged
WIP: Migrate to nnbd #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passsy
commented
Jan 3, 2021
|
|
||
| /// Returns an original collection containing all the non-null elements, | ||
| /// throwing an [StateError] if there are any null elements. | ||
| void requireNoNulls() { |
There was a problem hiding this comment.
Removal is fine, as this is now covered by the type system
# Conflicts: # lib/src/list.dart
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 96.31% 96.16% -0.15%
==========================================
Files 10 10
Lines 786 652 -134
==========================================
- Hits 757 627 -130
+ Misses 29 25 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, open for discussion.