Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whereNotNull should transform generic type to non-nullable. #125

Merged
merged 1 commit into from Mar 21, 2021

Conversation

hpoul
Copy link
Contributor

@hpoul hpoul commented Mar 21, 2021

whereNotNull() should transform a Iterable<int?> to an Iterable, I don't think there is a good reason that it's still nullable.

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #125 (401f5b0) into master (a446b94) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          10       10           
  Lines         653      653           
=======================================
  Hits          628      628           
  Misses         25       25           
Impacted Files Coverage Δ
lib/src/iterable.dart 99.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a446b94...401f5b0. Read the comment docs.

@passsy
Copy link
Collaborator

passsy commented Mar 21, 2021

Fantastic, I was just about to fix that :D

@passsy passsy merged commit c935525 into simc:master Mar 21, 2021
@passsy
Copy link
Collaborator

passsy commented Mar 22, 2021

Released as 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants