Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "radix" to toInt and toIntOrNUll #43

Merged
merged 3 commits into from Jan 22, 2020
Merged

Adding "radix" to toInt and toIntOrNUll #43

merged 3 commits into from Jan 22, 2020

Conversation

shinayser
Copy link
Contributor

I've added an optional parameter to String.toInt and String.toIntOrNull to parse strings in binary or hexadecimal format (or whatever radix you want).

@shinayser shinayser requested a review from simc January 22, 2020 20:19
simc
simc requested changes Jan 22, 2020
View reviewed changes
test/string_test.dart Show resolved Hide resolved
test/string_test.dart Outdated Show resolved Hide resolved
lib/src/range.dart Outdated Show resolved Hide resolved
@shinayser
Reverting IntRange modification (this belongs to another PR).
e5e8788 
Creating test group for toInt with/wthout radix.
@simc simc merged commit 4c136fb into simc:master Jan 22, 2020
@simc
Copy link
Owner

simc commented Jan 22, 2020 •
edited

Thanks for your contribution!

@shinayser shinayser deleted the int-radix branch January 22, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simc simc simc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shinayser @simc