Enabling Sound Null Safety #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarts
reviewed
Nov 30, 2020
haarts
reviewed
Nov 30, 2020
haarts
reviewed
Nov 30, 2020
haarts
reviewed
Nov 30, 2020
|
Would you mind me running |
|
Please do
…On Mon, Nov 30, 2020, 10:17 Nicolas Schlecker ***@***.***> wrote:
Would you mind me running dartfmt . since the there is a CI check
checking if darfmt would change something.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#73 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACTJDPUZIS6XEU7TKU5IDSSNPLNANCNFSM4T3Y52OQ>
.
|
|
Just wondering; did you 'just' run the |
|
This PR has a conflict with master which needs to be resolved. Can you also squash the commits into one? |
|
I did not use the migrate tool, will squash the commits tonight. |
|
Thank you for your significant contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #72 here is my PR. It's probably best to keep this on a separate branch on your end until null safety hits a stable release but I am not sure how to handle that so that's up to you.
You will probably have to change the google/dart container to use the dev tag in order for the checks to work