Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN 0.29 ios header issue #371

Closed
weixingsun opened this issue Jul 10, 2016 · 47 comments
Closed

RN 0.29 ios header issue #371

weixingsun opened this issue Jul 10, 2016 · 47 comments

Comments

@weixingsun
Copy link

weixingsun commented Jul 10, 2016

should we change
AIRMap.h line 12

import "React/RCTComponent.h"

AIRMapCallout.h line 7

import "React/RCTView.h"

to dir Views ?

@kfiroo
Copy link

kfiroo commented Jul 10, 2016

Any news about this? Can't build current version with RN0.29.0..
Thanks

@nascode
Copy link

nascode commented Jul 10, 2016

To fix, please change

AIRMap.h line 12
From #import <React/RCTComponent.h>
To #import "RCTComponent.h"

and

AIRMapCallout.h line 7
From #import "React/RCTView.h"
To #import "RCTView.h"

@kfiroo
Copy link

kfiroo commented Jul 10, 2016

Thanks @nascode this seems to work! 👍

kfiroo added a commit to kfiroo/react-native-maps that referenced this issue Jul 10, 2016
kfiroo added a commit to kfiroo/react-native-maps that referenced this issue Jul 10, 2016
@kfiroo
Copy link

kfiroo commented Jul 10, 2016

PR to resolve 373

@kfiroo
Copy link

kfiroo commented Jul 17, 2016

So apparently this PR does not really solve this issue as it only shifts the problem to users using Cocoapods.

When linking this lib manually imports need to be directly to the file RCT***.h
When using cocoapods imports need to be from react React/RCT***.h

@nascode @lelandrichardson @weixingsun Anyone has any input on how to resolve this?

Thanks

@jefflau
Copy link

jefflau commented Jul 22, 2016

Yeah, I still have this problem. Using the iOS MapView for now

@jmitch0901
Copy link

@nascode Thank you!

@pareekkhushboo77
Copy link

@nascode Thankyou soo much, i have been searching for the issue since long, and this solved..:)

@npomfret
Copy link

npomfret commented Aug 8, 2016

Any news on a fix. 0.7.1 still not working with RN0.31, getting the error 'React/RCTComponent.h' file not found on this live in AirMap.h:

#import <React/RCTComponent.h>

I have forked with @nascode's fix but don't understand why the main project doesn't work yet.

@GantMan
Copy link
Contributor

GantMan commented Aug 8, 2016

yeah, I too would like an update on the fix from 1 month ago.

@jefflau
Copy link

jefflau commented Aug 8, 2016

+1 I'm using the iOS component whilst I wait for this.

@julien-rodrigues
Copy link
Contributor

Just ran into this, this morning.. Although I updated the lib some times ago..

@kfiroo
Copy link

kfiroo commented Aug 12, 2016

@npomfret @GantMan @jefflau @julien-rodrigues
Guys, this issue has to do with the difference between installing this lib using cocoapods and manual linking so please make sure to specify how you installed it so we can help sort it out.

Thanks :)

@julien-rodrigues
Copy link
Contributor

manual for me :) Had to change the imports

@npomfret
Copy link

I don't use cocapods, I use rpm link (well now its react-native link i think). I think cocapods might be used less commonly.

@jefflau
Copy link

jefflau commented Aug 13, 2016

I also used rnpm link

Sent from my iPhone

On Aug 13, 2016, at 6:43 PM, Nick Pomfret <notifications@github.commailto:notifications@github.com> wrote:

I don't use cocapods, I use rpm link (well now its react-native link i think). I think cocapods might be used less commonly.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/371#issuecomment-239614798, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABKiFQfR3Rq0DZ6O27RBk0zy15-LE3ziks5qfZ_fgaJpZM4JIvA0.

@kfiroo
Copy link

kfiroo commented Aug 14, 2016

I also used manual linking and submitted the pull PR above that got it to work.

@lelandrichardson do we still have a problem with cocoapods installs?

@npomfret
Copy link

Feels like most people are manually linking (or using rnpm link / react-native link). Would it be possible to revert the change that broke manually linking and come up with another solution for cocapods?

@esutton
Copy link

esutton commented Aug 29, 2016

Is there a solution to work-around No visible @interface for 'RCTImageLoader'

@Exilz did you find solution?

Manual link did not help.

I removed path prefix from both both:

AIRMap.h line 12
#import "React/RCTComponent.h"

and

AIRMapCallout.h line 7
#import "React/RCTView.h"

I get following error in AIRMapMarker.m

/Users/edward3/Documents/projects/react-native/field-planner-mobile/node_modules/react-native-maps/ios/AirMaps/AIRMapMarker.m:212:58: No visible @interface for 'RCTImageLoader' declares the selector 'loadImageWithTag:size:scale:resizeMode:progressBlock:completionBlock:'

@esutton
Copy link

esutton commented Aug 29, 2016

Never mind, found solution to No visible @interface for 'RCTImageLoader' here: #456

@simonmitchell
Copy link
Contributor

Also manually linking and running into this error. This is why I have a massive amount of distaste for CocoaPods. Agree with others thoughts that a lot more people are manually linking or using rnpm link.

@npomfret
Copy link

I agree. Especially as 'manual' linking is built into the react-native command line now. Can we please get the PODS change reverted?

@chocnut
Copy link

chocnut commented Aug 30, 2016

how can we fix this?

@richeterre
Copy link

This seems to be fixed in react-native-maps version 0.8.0 👍

@spikebrehm
Copy link

spikebrehm commented Aug 31, 2016

I just released 0.8.0, which fixes this issue.

@s-lee
Copy link

s-lee commented Sep 8, 2016

I still have this problem. I am using 0.8.0 release with RN 0.32.0.

@kfiroo
Copy link

kfiroo commented Sep 8, 2016

@s-lee are you using cocoapods or manual linking?

@s-lee
Copy link

s-lee commented Sep 8, 2016

@kfiroo I am using cocoapods. Also, I checked all the changes need to be made when linking manually.

@spikebrehm
Copy link

@s-lee are you sure? 0.8.0 should have fixed that

@s-lee
Copy link

s-lee commented Sep 10, 2016

@spikebrehm yes, I was using 0.8.0 release with RN 0.32.0.
I just tested with react(15.3.1), react-native(0.33.0) and react-native-maps(0.8.2), and it fixed this issue 👍

@swyna52
Copy link

swyna52 commented Sep 15, 2016

Here I'm still having the issue while using react(15.3.1), react-native(0.33.0) and react-native-maps(0.8.2). The two header files are already patched. Tried both cocoapods and manual linking.

@arashbi
Copy link

arashbi commented Oct 14, 2016

I still experience the same issue in 0.10.1.

@dazwiafl
Copy link

+1 on 0.10.1

@jjzazuet
Copy link

+1 "version": "0.10.1"

@GantMan
Copy link
Contributor

GantMan commented Oct 22, 2016

Just experienced this on 10.2, and completely broken latest installs of our open source project :(

@soorajvnair
Copy link

Yes i experienced this too in the latest version.

@spikebrehm
Copy link

Can someone please provide a reproducible test case for this, such as a link to a repo for a minimal app that displays this error? We're not able to reproduce.

@spikebrehm
Copy link

@GantMan @soorajvnair can you paste the exact error you're seeing?

@GantMan
Copy link
Contributor

GantMan commented Nov 1, 2016

0.11.0 fixed this for me.

@MaheshNandam
Copy link

react - 16.0.0
react-native - 0.54

'React/RCTNetworking.h' file not found, did anyone resolve this?

@rborn
Copy link
Collaborator

rborn commented Apr 16, 2018

@MaheshNandam don't post the same question in multiple places.

@MaheshNandam
Copy link

MaheshNandam commented Apr 16, 2018

hey @rborn, placing the same question in multiple places is just to get a reply, don't mind, okay I got your intention.

Indeed, I have tried #import "RCTNetworking.h", but still haven't get the solution,

and tried deleting ios/build folder too,

do you have any idea to solve this?

@rborn
Copy link
Collaborator

rborn commented Apr 16, 2018

While you try to get a reply, people subscribed to the repo will get multiple notifications/emails because of this, so please don't do it.

It's a setup issue, try to set up the project as specified in the installation instructions.

@kevinzhangftw
Copy link

kevinzhangftw commented Jun 28, 2018

hi, i am having the same problem
#import <React/RCTNetworking.h> file not found
using cocoapods

Podfile

target 'bglocation' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  # Pods for bglocation
pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
#https://github.com/facebook/react-native/issues/13046
pod 'React', :path => '../node_modules/react-native'
  pod 'RNBackgroundGeolocation', :path => '../node_modules/react-native-background-geolocation'
  pod 'RNBackgroundFetch', :path => '../node_modules/react-native-background-fetch'
pod 'React', :path => '../node_modules/react-native', :subspecs => ['DevSupport']
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests