0.4 stable #276
Merged
0.4 stable #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2016 09:46
…ix Android 6 issue on some devices
|
Thanks for finding the issue and fixing it! I think the example app will need to be updated too. |
|
@locly Nice! Yea, could you update the example to pass |
|
Yes - have updated the example to declare the package with |
|
@locly looks good! thanks for the PR merging |
|
@locly just realized this was for the 0.4-stable branch. I think this should also work for master, any reason not too? |
jrichardlai
added a commit
to jrichardlai/react-native-maps
that referenced
this pull request
Jun 13, 2016
Merged
BigPun86
pushed a commit
to BigPun86/react-native-maps
that referenced
this pull request
Dec 1, 2016
markdgo
pushed a commit
to markdgo/react-native-maps
that referenced
this pull request
Mar 15, 2021
MarcoAntonioAG
pushed a commit
to MarcoAntonioAG/React-map
that referenced
this pull request
Mar 31, 2022
joshpeterson30489
added a commit
to joshpeterson30489/maps-develop-with-react-native
that referenced
this pull request
Sep 30, 2022
superstar1205
added a commit
to superstar1205/Map-ReactNative
that referenced
this pull request
Dec 26, 2022
anthony0506
added a commit
to anthony0506/react-native-maps
that referenced
this pull request
Mar 19, 2023
johney6767
pushed a commit
to johney6767/Map-ReactNative
that referenced
this pull request
May 31, 2023
GoldenDragon0710
added a commit
to GoldenDragon0710/google-map-react-native
that referenced
this pull request
Nov 27, 2023
PainStaker0331
pushed a commit
to PainStaker0331/react-native-maps
that referenced
this pull request
Mar 3, 2024
Super-CodeKing
added a commit
to Super-CodeKing/react_native_map
that referenced
this pull request
Apr 26, 2024
fairskyDev0201
pushed a commit
to fairskyDev0201/react-native-maps
that referenced
this pull request
Apr 29, 2024
DavidLee0501
added a commit
to DavidLee0501/React-Native-Map
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for#165 and #271 - Android 6.0 crashing on devices such as Xperia Z5 Compact, Z5 Bond and others.
It passes the activity to the package, manager and view so that it can be used in place of the app context when initialising the MapView component.
The new code as also been tested on the following devices to ensure it continues to work as before:
Nexus 4 (Android 5), Nexus 5 (Android 6), Nexus 6P (Android 6)
It requires a change to an app's MainActivity.java to pass
thiswhen creating the AirPackage:new AirPackage(this)rather thannew AirPackage()in the current version.