Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute data to Character endpoint (40 characters exists) #18

Closed
lelouchB opened this issue Oct 6, 2020 · 5 comments
Closed

Contribute data to Character endpoint (40 characters exists) #18

lelouchB opened this issue Oct 6, 2020 · 5 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects

Comments

@lelouchB
Copy link
Owner

lelouchB commented Oct 6, 2020

The /character endpoint currently has 25 40 characters. (Update #25 )

There are still few characters that we can add to this endpoint.

Contribute data for individual characters of Final Space in the given schema.

Resource: https://final-space.fandom.com/wiki/Category:Characters

P.S. You can leave the field for img_url.

You can send a PR with the data in JSON format to the endpoint branch under character folder.

Please check if the data for that character exists.

Here is the schema for /character endpoint:

Key Type Description
id int The id of the character (starting from 1).
name string The name of the character.
status string The status of the character.
species string The species of the character.
gender string The gender of the character.
hair string The hair color of the character.
origin object Name of the character's origin location.
abilities array Different abilities of character.
alias array Different names of character.
img_url string (url) Link to the character's image.
@lelouchB lelouchB added this to To do in v1.0.0 Oct 6, 2020
@lelouchB lelouchB pinned this issue Oct 6, 2020
@lelouchB lelouchB added help wanted Extra attention is needed up-for-grabs labels Oct 6, 2020
@stevenjburrows
Copy link

I will add some more to this for you.

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

Thanks @stevenjburrows
I will assign this issue to you then.

@lelouchB lelouchB assigned lelouchB and stevenjburrows and unassigned lelouchB Oct 6, 2020
@lelouchB lelouchB moved this from To do to In progress in v1.0.0 Oct 6, 2020
@stevenjburrows
Copy link

I will add some more to this for you what do you want for origin as the wiki doesn't mention it for the three I have looked at

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

Hey,
You can add Unknown in such cases,

There are many characters with less information,

You can refer here for more such queries,

https://finalspaceapi.com/api/v0/character

Thanks

@lelouchB lelouchB linked a pull request Oct 6, 2020 that will close this issue
@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

Update : After #25 there are 40 characters in the database now, I am keeping this issue open, just in case someone come across a character that isn't present in the database and want to work on it.

@lelouchB lelouchB unpinned this issue Oct 6, 2020
@lelouchB lelouchB changed the title Contribute data to Character endpoint Contribute data to Character endpoint (40 characters exists) Oct 7, 2020
@lelouchB lelouchB moved this from In progress to Done in v1.0.0 Oct 11, 2020
@lelouchB lelouchB moved this from Done to Shipped to Production in v1.0.0 Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
v1.0.0
Shipped to Production
Development

Successfully merging a pull request may close this issue.

2 participants