Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge opened PRs into gh-pages branch #171

Merged
merged 3 commits into from Feb 25, 2016

Conversation

benoittgt
Copy link
Collaborator

Doing the assign tasks from #168 (comment)
Closes #138, closes #164

Was not able to found any book links for #137. So didn't fixe this one. Was simpler to redo all the changes. Less git more vim. 馃挄

Edited by @onebree to unlink PR 135.

@onebree
Copy link
Contributor

onebree commented Feb 24, 2016

@benoittgt I see what you mean -- If it is not too much trouble, you can create another PR which adds a "Resources" section before "Contributing".

Also, I may not have been clear, but the point of this PR was to grab the commits that others have made and implement them in gh-pages. I want the original PR authors to have their commits published, as they helped us out. I can better explain this on Slack if you need help.

Sop as of right now, I am adding [WIP] to this PR title.

@onebree onebree changed the title Prs in gh page [WIP] Merge opened PRs into gh-pages branch Feb 24, 2016
@benoittgt
Copy link
Collaborator Author

No problem I can do the merge. I will redo the changes.

@benoittgt benoittgt closed this Feb 24, 2016
@onebree
Copy link
Contributor

onebree commented Feb 24, 2016

@benoittgt you did not need to close this PR -- you could have just done git reset --hard <parent-of-c35ee29> and git push origin <branch-name> --force

@benoittgt benoittgt reopened this Feb 24, 2016
@benoittgt
Copy link
Collaborator Author

Did a try at lunch time. Damn too long. Sorry @onebree. I know it's important to keep history of who commit but I can't fixe for each PR so many merge conflicts on Gemfile.lock, Procfile... to add an s to "RSpec" or whatever... 馃槙

@onebree
Copy link
Contributor

onebree commented Feb 25, 2016

@benoittgt I took a stab at it myself. Following my initial instructions brought all the old files back, which is not what we want. From there, I tried cherry-pick, but this did the same thing. I am going to merge your PR, and just include the helpful usernames in the commit message.

As a note, I looked up #135, and it deals with the currently-missing "Resources" section. I will edit your comment to remove that PR, so it does not close.

Thank you for the help!

@onebree onebree changed the title [WIP] Merge opened PRs into gh-pages branch Merge opened PRs into gh-pages branch Feb 25, 2016
onebree added a commit that referenced this pull request Feb 25, 2016
Merge opened PRs into gh-pages branch
Original commits by: @DavidS (910b418), @nhashmi (bb52c78)
@onebree onebree merged commit 0c485ff into betterspecs:gh-pages Feb 25, 2016
@benoittgt
Copy link
Collaborator Author

Thanks @onebree 馃憦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants