Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messed up windows deployment #1373

Open
tmheath opened this issue May 23, 2024 · 0 comments
Open

Messed up windows deployment #1373

tmheath opened this issue May 23, 2024 · 0 comments

Comments

@tmheath
Copy link

tmheath commented May 23, 2024

My Problem

I fixed this in a prior release a long time ago, the launch process has changed since then.
I updated the fork I'd used and where it pointed the launcher still had the old filenames.
I don't understand where the launching details were moved to or otherwise how they are
generated at build to be renamed as they are in the download. If I'm given the info then
I'll submit a PR to the proper repo. Without these fixes, lem will only launch from the local
directory and when called from an existing command prompt will close that command
prompt.

Problems

The most recent SDL2 Windows release downloaded with lem.bat both closing the terminal when called via terminal which is annoying if not run from a start menu or double clicked. I've deleted the exit command from the file to fix this, behavior via other launch methods remain unchanged.

There is also a bug in the current version fixed by adding %~dp0 in front of the calling line to the exe filename, this change enabled launching via start menu as prior to this the launcher would just crash.

The modified launcher

@echo off
set PATH=%~dp0lib;%PATH%
start "" "%~dp0lem-internal.exe"

From

@echo off
set PATH=%~dp0lib;%PATH%
start "" "lem-internal.exe"
exit

Hoping to use common lisp for a small side project in personal life, excited to try getting involved with this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant