Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: persist the filters selection when searching #14

Closed
yuderekyu opened this issue Jan 23, 2024 · 2 comments
Closed

feature request: persist the filters selection when searching #14

yuderekyu opened this issue Jan 23, 2024 · 2 comments

Comments

@yuderekyu
Copy link

sick repo ✨ curious if we could convert the filters selection page to a persistent filters search bar that appears above the results page? this would make it easier for a user to update their search criteria without having to navigate between the pages.

@lemeryfertitta
Copy link
Owner

I originally had this as a one page app. I found that it felt like the page started to get cluttered and hard to navigate, so I broke it apart. I've been using the app while boarding, and I personally find it pretty easy to update the search criteria by hitting the back button (either via browser or the small link on the results page), but I'm open to a change if there is a clean design. Did you have any particular design in mind? Maybe a screenshot, diagram, or similar could help.

Just looking at Google now, Climbdex seems a little trickier because there are more options, and there has to be space for the large, collapsible hold filter.

@yuderekyu
Copy link
Author

oh duh, i totally skimmed and forgot about the collapsible hold filter which is huge feature here lmao. i'm actually going to close this issue and will reopen if/once i have a clear design in mind!

@yuderekyu yuderekyu closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants