Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't seem to work with Spring Boot 2.7.x with Hibernate 5.6.x #2

Open
slobodator opened this issue Nov 15, 2023 · 2 comments
Open

Comments

@slobodator
Copy link

Hi Lemick,

Your tool seems to be a nice replacement for Vlad's SQLStatementCountValidator.
But it forces to use Hibernate 6 because HibernateSQLCountTestListener imports jakarta.persistence.EntityManager.
We are still using Spring Boot 2.7.x (with Hibernate 5.6.x).
Would you be so kind to have a backport for Hibernate 5, please?

Best regards,
Andriy

@slobodator
Copy link
Author

Trying to prepare a pull request myself, replacing <artifactId>hibernate-core-jakarta</artifactId> with <artifactId>hibernate-core</artifactId> but the tests fail, digging in.

@Lemick
Copy link
Owner

Lemick commented Nov 15, 2023

Hi, thanks, I have not a lot of time to look at it at the moment, but I will keep that in mind. If you achieve to do it, feel free to open a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants