Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergeSortedFiles with BufferedWriter cannot be used #20

Closed
wavyx opened this issue May 4, 2019 · 7 comments
Closed

mergeSortedFiles with BufferedWriter cannot be used #20

wavyx opened this issue May 4, 2019 · 7 comments

Comments

@wavyx
Copy link

wavyx commented May 4, 2019

I'm trying to use the merge method with a GZIPOutput Buffered writer.
The method mergeSortedFiles(BufferedWriter fbw, final Comparator cmp, boolean distinct, List buffers) looks perfect, but the dependency to BinaryFileBuffer makes it impossible to use.
As BinaryFileBuffer is a non-public child class, you cannot use it externally and you cannot extend it either.
Could you just make the BinaryFileBuffer a standard public class in its own file?

Thanks

@wavyx
Copy link
Author

wavyx commented May 4, 2019

Well it looks fixed in 0.3.0
But I'm still relying on 0.2.5 as it was not bumped in maven repository https://search.maven.org/search?q=g:com.google.code.externalsortinginjava%20AND%20a:externalsortinginjava

@lemire
Copy link
Owner

lemire commented May 4, 2019

The maven repo is a bit finicky, let us try to issue a new release.

@lemire
Copy link
Owner

lemire commented May 6, 2019

We had to disable javadoc due to a long-standing bug preventing releases with recent JDKs, but otherwise, version 0.3.1 should appear on the maven repo.

@lemire lemire closed this as completed May 6, 2019
@wavyx
Copy link
Author

wavyx commented May 7, 2019

Thanks for the new release, but it looks like it's still not visible in maven repo :'(
https://repo.maven.apache.org/maven2/com/google/code/externalsortinginjava/externalsortinginjava/

@lemire
Copy link
Owner

lemire commented May 8, 2019

I think you have to be patient. In my experience, it can take up to 48 hours. If it does not get resolved in the next 36 hours, please ping me.

I did the release, I have the commit logs to prove it. There were no error that I could see on my end.

@wavyx
Copy link
Author

wavyx commented May 8, 2019

Indeed I thought it was almost "realtime".
0.3.1 is online now, thanks again for your help!

@lemire
Copy link
Owner

lemire commented May 8, 2019

Indeed I thought it was almost "realtime".

You would think so, wouldn't you? Sometimes it appears right away, sometimes there is a long delay. There seems to be no reason for it all.

It is very frustrating. It means that there is no way to verify that it worked after releasing the command... you have to wait...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants