Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all sklearn estimator checks passing #21

Closed
aazuspan opened this issue May 13, 2023 · 1 comment · Fixed by #44
Closed

Get all sklearn estimator checks passing #21

aazuspan opened this issue May 13, 2023 · 1 comment · Fixed by #44
Assignees
Labels
estimator Related to one or more estimators testing Related to test code or data

Comments

@aazuspan
Copy link
Contributor

aazuspan commented May 13, 2023

As discussed in #20, we've run into a number of issues that probably would have been caught earlier with the built-in test suite in the sklearn.utils.estimator_checks module, so it's probably in our best interest to focus on getting those passing. This should also potentially allow us to remove some redundant tests from test_estimators.py.

Note that it seems like some valuable tests like check_dataframe_column_names_consistency aren't running automatically, so we'll need to make sure we run everything that's relevant.

EDIT: Our tests currently contain commented-out checks for our estimators, but it looks like there are also transformer checks that we should run. In fact, maybe it would make sense to get our transformers passing first since those will affect the estimator results?

Another aspect that I'm not very familiar with but that we'll probably need to dive into for this is the sklearn tag system, which allows you to specify different compatibility options for estimators and transformers that inform which checks will be run.

@aazuspan aazuspan added testing Related to test code or data estimator Related to one or more estimators labels May 13, 2023
@grovduck grovduck added this to the Core Estimators milestone Jun 7, 2023
@aazuspan aazuspan self-assigned this Jul 19, 2023
@aazuspan aazuspan mentioned this issue Jul 19, 2023
4 tasks
@aazuspan aazuspan linked a pull request Jul 19, 2023 that will close this issue
4 tasks
@aazuspan
Copy link
Contributor Author

Resolved by #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimator Related to one or more estimators testing Related to test code or data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants