-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change installed name to sknnr
#61
Comments
This will be a brand new step in my evolution (posting a package to PyPI)! Sounds intimidating, but I'll follow your lead here and I'm fully supportive of snagging the name. |
@aazuspan, wondering if this is the right time to make this package name change now that we have at least three packages that are depending on it ( |
Yeah, great point. I think it's time! I'll rename the repo and make a quick PR with the
Want to do it live over Zoom? |
I can't tell if you're mocking me 😉, but, yes, I'd love to see you do that ... |
Haha, not at all! I can screenshare the process, as long as you don't mind watching me fumble my way through the authentication (they just switched how they handle credentials, so my last release took a while to get right!). |
Perfect, just invited you.
Yes. Github redirects so it shouldn't be crucial to update anything, but I did update my remote URL with FYI I just found out pip will apparently install a pre-release without the |
Ah, thanks for this tip. I would have not done this!
Agreed, I'm not too worried either. |
Just found a small formatting issue on PyPI with footnotes.
It mentions |
Our previous plan was to use
scikit-learn-knn-regression
as the installed name of the package andsknnr
as the imported name, but per the discussion in #59, we're now tentatively planning to usesknnr
across the board.Pros for switching to
sknnr
:Cons for switching to
sknnr
:scikit-learn
Making the switch will be pretty straightforward, and should just require updating the
pyproject.toml
, the repository name on Github, and links to the repository throughout the docs (although Github will continue to redirect).If we do make a final decision to go with
sknnr
on PyPI, I suggest we make an alpha release just to claim the package name (pre-releases can only be installed withpip install sknnr --pre
, so it should be clear that it is not an official, stable release if anyone comes across it).The text was updated successfully, but these errors were encountered: