New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using pluggy for plugin management #329

Open

lemon24 opened this issue Dec 2, 2023 · 0 comments

Labels

Owner

lemon24 commented Dec 2, 2023 •

edited

https://pluggy.readthedocs.io/

Pros:

widely used (pytest, tox, datasette)
standardization
validation (all hooks have specs, argument names)
opt-in arguments, deprecations (API evolution)
discovery (via setuptools entry points)
plugin management (plugin == named connection of hooks)
some exception handling
debugging support
already documented

Cons:

extra dependency
widely used => harder to contribute to (Great care must taken when hacking on pluggy since multiple mature projects rely on it.)
update-style hooks where we continue to run after failure may be fiddly to implement
requests wrapper style hooks where the return value from a plugin is passed to the next plugin might be fiddly to implement
LIFO order
how would lazy plugin loading work?

lemon24 added core plugin labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment