Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] min/max and operator options to the exports.mathExpr, extended d tests and (english) readme #33

Merged
merged 2 commits into from
May 3, 2019

Conversation

j-d-carmichael
Copy link
Contributor

If you require tougher math expressions these additional options allow this now: mathOperator mathMin mathMax added with default values to ensure this is a non-breaking change to the existing code base.

@lichaozhy
Copy link
Member

There are many design problems in v1.x. They are all my mistakes. I would rather stop maintaining for v1.x. Do you really need me to release a new version? Or we should refactor v3.x? I have a lot of new ideas about that.

But if you really need v1.x to be released, I will accept it. The version will be v1.4.0.

@j-d-carmichael
Copy link
Contributor Author

Currently I have pulled this into my project directly from github but this is not a nice solution for when my current project goes live in a month or so. Therefore if it is not too much trouble to release this to v1 that would be great.

@lichaozhy lichaozhy merged commit 7f26cd6 into produck:1.x May 3, 2019
@lichaozhy
Copy link
Member

As you wish 😋

@j-d-carmichael
Copy link
Contributor Author

j-d-carmichael commented May 3, 2019

:D you absolute star! Thank you!

(looking forward to seeing the release of v3!)

@kerem3322
Copy link

merhaba site kurcamda yardımcı olurmusun ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants