Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_AdbStreamConnection should be removed. #23

Merged
merged 3 commits into from May 17, 2022
Merged

_AdbStreamConnection should be removed. #23

merged 3 commits into from May 17, 2022

Conversation

MilkFlavor
Copy link
Contributor

According to " openatx/adbutils#46 (comment) ", the _AdbStreamConnection class was removed. I faced an error where the error was not found.

@MilkFlavor MilkFlavor changed the title _AdbStreamConnection should be removed removed. _AdbStreamConnection should be removed. May 16, 2022
@leng-yue
Copy link
Owner

The . is important for unit tests and importing outside the scrcpy_ui folder. You probably need to revoke the change.

@leng-yue
Copy link
Owner

You probably also need to update the minimum version of adbutils in the pyproject.toml, or add a try except instead.

@leng-yue
Copy link
Owner

Thanks for your contribution.

@leng-yue leng-yue added the bug Something isn't working label May 16, 2022
@leng-yue leng-yue merged commit a4daad4 into leng-yue:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MilkFlavor @leng-yue