Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash in SSID breaks the network details URL #341

Closed
samuelkf opened this issue Mar 24, 2021 · 11 comments
Closed

Slash in SSID breaks the network details URL #341

samuelkf opened this issue Mar 24, 2021 · 11 comments
Milestone

Comments

@samuelkf
Copy link

Clicking on the network details link for a network with a / in its SSID results in a 404 error. Replacing the slash in the url with the encoded form %2F results in the expected page being displayed.

I haven't tested with any other non-alphanumeric characters, but I'm sure there are plenty of other l33t h4xors like me out there who put stupid symbols in their SSIDs...

@lennartkoopmann
Copy link
Member

Ugh, that's a little embarrassing. Sorry about that. I'm investigating and will build a bugfix release ASAP.

@lennartkoopmann lennartkoopmann added this to the 1.0.1 milestone Mar 25, 2021
@lennartkoopmann lennartkoopmann modified the milestones: 1.0.1, 1.1.0 Mar 31, 2021
@lennartkoopmann
Copy link
Member

Hi,

I just tried to reproduce this but it seems to work for me:

2021-04-17-115112_407x86_scrot

What browser did you use and where exactly was that link that you clicked on? Maybe a different link is not using the <SSID/> component that properly escapes.

Thank you!

@lennartkoopmann lennartkoopmann modified the milestones: 1.1.0, 1.x Apr 17, 2021
@samuelkf
Copy link
Author

This was with Firefox on Windows (whatever the latest versions of both Win 10 and Firefox are). I’ll fire it back up and capture a bit more detail about it.

@lennartkoopmann lennartkoopmann removed this from the 1.x milestone Apr 24, 2021
@benroeder
Copy link

I am running into the same issue

It tries to navigate to http://:22900/networks/show/02:0e:58:8f:ef:8e/SNS/AhAEAQAAAAAOWI7vjgG=/5/

The SSID is SNS/AhAEAQAAAAAOWI7vjgG=

If I manually url encode the / to %2F it works, so I am guessing the urls are not cleaned/escaped ?

This happens on chrome, safari and Firefox on macOS.

The page link is
networks -> select netwrok with slash -> click on SSID column link

Does make me wonder what else I can put into a SSID, and what fun can be had :-)

@lennartkoopmann
Copy link
Member

I'll try to get a hold of a macOS to try this.

The URLS should are URL-escaped, but something is off here. Can you tell me which link exactly you followed? Want to make sure we are looking at the same one.

@lennartkoopmann lennartkoopmann added this to the 1.2.0 milestone May 14, 2021
@benroeder
Copy link

image

Copied link
http://:22900/networks/show/02%3A0e%3A58%3A8e%3Aef%3A8e/SNS%2FAhAEAQAAAAAOWI7vjgA%3D/4
weird which is escaped
but goes to http://snip:22900/networks/show/02:0e:58:8e:ef:8e/SNS/AhAEAQAAAAAOWI7vjgA=/4/
In the source
SNS/AhAEAQAAAAAOWI7vjgA=
SNS/AhAEAQAAAAAOWI7vjgA=
SNS/AhAEAQAAAAAOWI7vjgA=

@benroeder
Copy link

Also just to confirm
You are running the latest stable version of nzyme: 1.1.0 built at [2021-04-24T01:08:53Z].

@benroeder
Copy link

Also confirm this happens on windows 10 as well.

The raw BSSID is SNS/AhAEAQAAAAAOWI7vjgA=

@lennartkoopmann
Copy link
Member

Thank you! I'm investigating.

@benroeder
Copy link

OK it has changed this morning, I am not sure what has changed ???
The SSID has changed to "SONOS, SNS/AhAEAQAAAAAOWI7vjgA=" and now appears as the attached
Screenshot 2021-05-17 at 09 48 00

Which when opened up shows SONOS and SNS/AhAEAQAAAAAOWI7vjgA= as separate networks.
Screenshot 2021-05-17 at 09 48 09

Is this something to do with the comma in the name ?

Clicking on SONOS works as expected, SNS/AhAEAQAAAAAOWI7vjgA= leads to a 404

Hope this helps

@lennartkoopmann
Copy link
Member

The forward slash is breaking it. I'm working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants