Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore node: modules #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ben-harris-5
Copy link

Closes #7 . If a module being imported starts with node:, it's a builtin module, and therefore should never trigger this lint rule.

@benasher44
Copy link

Made a fork here that I am publishing. Would be happy to merge and publish this PR as well!

@ben-harris-5
Copy link
Author

Oh! Yeah, feel free to steal this change and put it in there if you'd like!

@benasher44
Copy link

Published 1.1.3 which uses the is-builtin-module package, which handles this and some other edge cases.

@ben-harris-5
Copy link
Author

I don't see a version 1.1.3 in NPM:

$ npm view eslint-plugin-implicit-dependencies versions
[
  '1.0.0', '1.0.1',
  '1.0.2', '1.0.3',
  '1.0.4', '1.1.0',
  '1.1.1'
]

Am I missing something?

@benasher44
Copy link

Ah yeah it's a fork, so I published it under @benasher44/eslint-plugin-implicit-dependencies. You'll need to prefix your eslint config references with @benasher44/ as well

@ben-harris-5
Copy link
Author

OK, that makes sense, thanks!

Is the "original" project here dead? :(

@benasher44
Copy link

Np. Not sure — seems like it might be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reports native modules
2 participants