Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Error not returned #237

Open
pichoemr opened this issue Apr 24, 2023 · 3 comments
Open

[Bug]: Error not returned #237

pichoemr opened this issue Apr 24, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pichoemr
Copy link
Contributor

pichoemr commented Apr 24, 2023

What happened?

With some errors when opening the socket, the actual error is not returned, which causes a 500 error (default error code) and infinite loading.

Example:

  • Opening an application that does not have a build (or first build is pending)
  • Trying to open an unknown application (for example /app/12) causes an infinite loading and returns the default error (500) in the socket.

It seems that the error page no longer displays, probably due to a mismatch between the server's return and the client's expectation or a format error in the server's return.

@pichoemr pichoemr added the bug Something isn't working label Apr 24, 2023
@taorepoara taorepoara assigned pichoemr and unassigned taorepoara Apr 24, 2023
@pichoemr pichoemr closed this as completed May 2, 2023
@pichoemr pichoemr reopened this May 2, 2023
@taorepoara
Copy link
Contributor

We need more informations on when it happens before resolving it

@pichoemr
Copy link
Contributor Author

@lenra-io/devs I have added a few cases where we have no feedback

@Nesqwik
Copy link
Member

Nesqwik commented May 24, 2023

The infinite loading issue is a client-side issue. It should be fixed independantly.
We should add a Fallback for the default unknown issue client-side then server side and then only fix the 500 error to return a proper error.

If we only fix the error itself, any future 500 will create UI bug and/or no error displayed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🟡 Backlog
Development

No branches or pull requests

3 participants