Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Readline Commands are intercepted #2011

Open
Nuru opened this issue Jan 24, 2021 · 1 comment
Open

Terminal Readline Commands are intercepted #2011

Nuru opened this issue Jan 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Nuru
Copy link

Nuru commented Jan 24, 2021

Describe the bug
Terminal Readline Commands are intercepted by Lens as Lens commands rather than being passed to Readline.

When exec-ing into a pod and getting a bash shell, bash provides Readline Commands bound to non-printing characters for editing the command line. While Lens' input focus is a terminal, non-printing characters should be sent to the terminal, not intercepted by Lens.

Note: this is separate from:

To Reproduce
Steps to reproduce the behavior:

  1. In Lens, select the Pods display from the sidebar and use Lens to open a shell in a pod that has bash installed
  2. At the shell prompt (in the pod shell) type 'abcd' (do not type return) and note the cursor is after the 'd'
  3. Type ctrl-a and note the cursor moved to before the 'a'
  4. Type ctrl-f and note the cursor moved forward to between the 'a' and 'b', which is correct and expected, but the input focus has shifted from the terminal command line to the search box in the upper right of the UI window, which is wrong.
  5. Type 'x' and note it appears in the search box, not on the command line

Expected behavior
While the input focus is in the pod shell window, keyboard input that generates a character should be sent to the pod shell and not intercepted or interpreted by Lens.

Environment (please complete the following information):

  • Lens Version: 4.0.8
  • OS: macOS X 10.15.7
@Nuru Nuru added the bug Something isn't working label Jan 24, 2021
@jim-docker jim-docker added this to the 4.2.0 milestone Jan 25, 2021
@Nokel81
Copy link
Collaborator

Nokel81 commented Jan 25, 2021

Note: the shortcut key code is in src/renderer/components/input/search-input.tsx.

@Nokel81 Nokel81 modified the milestones: 4.2.0, 4.3.0 Mar 9, 2021
@Nokel81 Nokel81 modified the milestones: 4.3.0, 5.0.0 Mar 23, 2021
@msa0311 msa0311 modified the milestones: 5.0.0, 5.0.1 Jun 14, 2021
@jakolehm jakolehm modified the milestones: 5.0.1, 5.0.3 Jul 5, 2021
@Nokel81 Nokel81 modified the milestones: 5.0.3, 5.1.0, 5.1.1, 5.1.2 Jul 12, 2021
@Nokel81 Nokel81 modified the milestones: 5.1.2, 5.1.3, 5.2.0 Jul 19, 2021
@jim-docker jim-docker modified the milestones: 5.2.0, 5.2.4, 5.2.5 Sep 21, 2021
@jakolehm jakolehm modified the milestones: 5.2.5, 5.2.6 Oct 1, 2021
@Nokel81 Nokel81 modified the milestones: 5.2.6, 5.2.7 Nov 8, 2021
@Nokel81 Nokel81 removed this from the 5.2.7 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants