Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated conversion from string constant to char* #612

Closed
bronger opened this issue Apr 13, 2015 · 2 comments
Closed

deprecated conversion from string constant to char* #612

bronger opened this issue Apr 13, 2015 · 2 comments
Assignees
Labels
sf-archive Moved over from SourceForge

Comments

@bronger
Copy link
Contributor

bronger commented Apr 13, 2015

I have a build warning with gcc 4.8.2.

lensfun-code/tests/test_modifier.cpp:46:147: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]
char* geom_names [] = {"rectilinear", "panoramic", "equirect", "fisheye", "fisheye-equisolid", "fisheye-orthographic", "fisheye-thoby", NULL};

lensfun-code/tests/test_modifier.cpp:46:147: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]

Shouldn't string literals be an array of N const char* ?

Find attached a patch, it fixes this and deprecated doxyfile tags.

Reported by: rconstruct

@bronger
Copy link
Contributor Author

bronger commented Apr 19, 2015

Thanks, I have applied your patch.

Original comment by: seebk

@bronger
Copy link
Contributor Author

bronger commented Apr 19, 2015

  • status: open --> fixed
  • assigned_to: seebk

Original comment by: seebk

@bronger bronger added sf-archive Moved over from SourceForge warning labels Apr 23, 2019
@bronger bronger closed this as completed Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sf-archive Moved over from SourceForge
Projects
None yet
Development

No branches or pull requests

2 participants