Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FunkSVD to separate package #378

Closed
mdekstrand opened this issue May 6, 2024 · 1 comment · Fixed by #418
Closed

Move FunkSVD to separate package #378

mdekstrand opened this issue May 6, 2024 · 1 comment · Fixed by #418
Assignees
@mdekstrand
Labels
algorithms LensKit algorithm implementations
Milestone
2024.1

Comments

@mdekstrand
Copy link
Member

mdekstrand commented May 6, 2024 •
edited

Pursuant to #374, we need to move FunkSVD off of Numba to either PyTorch, or into a separate package that does still depend on Numba just for historical continuity.
@mdekstrand mdekstrand added the algorithms LensKit algorithm implementations label May 6, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone May 6, 2024
@mdekstrand mdekstrand self-assigned this May 6, 2024
@mdekstrand mdekstrand mentioned this issue May 6, 2024
Closed
@mdekstrand
Copy link
Member Author

Might keep this one on Numba, just as a demo. It would live in a separate repo.

@mdekstrand mdekstrand changed the title Move FunkSVD off of Numba Move FunkSVD to separate package Jun 3, 2024
@mdekstrand mdekstrand mentioned this issue Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdekstrand mdekstrand

Labels
algorithms LensKit algorithm implementations
Projects
LensKit Overhaul
Status: Done
Milestone
2024.1
Development

Successfully merging a pull request may close this issue.

Split FunkSVD into separate package in a monorepo mdekstrand/lkpy
1 participant
@mdekstrand