Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started code not executable #56

Closed
rburke2233 opened this issue Jan 10, 2019 · 1 comment
Closed

Getting Started code not executable #56

rburke2233 opened this issue Jan 10, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@rburke2233
Copy link

It is not possible to use the Getting Started notebook as is. The following line:

fittable = util.clone(algo)

generates the following error:

AttributeError: module 'lenskit.util' has no attribute 'clone'

This statement from the documentation is also incorrect:

"LensKit algorithms are compatible with SciKit clone, however, so feel free to use that if you need more general capabilities."

Attempting to clone LK algorithms with sklearn.base.clone() provides the following error:

TypeError: Cannot clone object '<lenskit.algorithms.item_knn.ItemItem object at 0x61df95c50>' (type <class 'lenskit.algorithms.item_knn.ItemItem'>): it does not seem to be a scikit-learn estimator as it does not implement a 'get_params' methods.

@mdekstrand
Copy link
Member

Temporary fix: the default docs are now for the released version.

Upcoming fix: releasing the next version with the new SciKit-style API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants