Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mobile menu drawer #1547

Merged
merged 43 commits into from Jan 13, 2023
Merged

feat: mobile menu drawer #1547

merged 43 commits into from Jan 13, 2023

Conversation

sasicodes
Copy link
Contributor

@sasicodes sasicodes commented Jan 6, 2023 •
edited

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@height
Copy link

height bot commented Jan 6, 2023 •
edited

This pull request has been linked to and will mark 1 task as "Done" when merged:

  • T-2600 Implement drawer in mobile view for user profile menu development (unlink task)

Previously linked tasks:

💡Tip: You can link multiple Height tasks to a pull request.

@vercel
Copy link

vercel bot commented Jan 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 3:51AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
api ⬜️ Ignored (Inspect) Jan 13, 2023 at 3:51AM (UTC)

@vercel vercel bot temporarily deployed to Preview – api January 9, 2023 05:43 Inactive
@sasicodes sasicodes self-assigned this Jan 9, 2023
@sasicodes sasicodes marked this pull request as ready for review January 9, 2023 14:08
@sasicodes sasicodes requested a review from bigint as a code owner January 9, 2023 14:08
@vercel vercel bot temporarily deployed to Preview – api January 9, 2023 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – api January 10, 2023 06:07 Inactive
bigint
bigint requested changes Jan 10, 2023
View reviewed changes
apps/web/src/components/Shared/Navbar/BottomNavigation.tsx Show resolved Hide resolved
apps/web/src/store/app.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – api January 10, 2023 08:39 Inactive
@sasicodes
Copy link
Contributor Author

sasicodes commented Jan 12, 2023 •
edited

is this modal scrollable? we can test with 100 fake profiles I guess

WITH max-h-[80vh]
image

@bigint
Copy link
Member

bigint commented Jan 12, 2023 •
edited

Screen.Recording.2023-01-12.at.4.21.12.PM.mov

clicking on whitespace not working 👀

@bigint
Copy link
Member

bigint commented Jan 12, 2023

Screen.Recording.2023-01-12.at.4.26.00.PM.mov

same here too 👀

@bigint
Copy link
Member

bigint commented Jan 12, 2023

Screen.Recording.2023-01-12.at.4.33.37.PM.mov

here too

@bigint
Copy link
Member

bigint commented Jan 12, 2023

some areas are not clickable on mobile as well

Screen.Recording.2023-01-12.at.4.35.10.PM.mov

bigint
bigint requested changes Jan 12, 2023
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sasicodes left some review 🙏🏼

apps/web/src/components/Shared/SwitchProfiles.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/SwitchProfiles.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/NavItems/YourProfile.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/NavItems/ThemeSwitch.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/SignedUser.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/NavItems/StaffMode.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/NavItems/StaffMode.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/NavItems/Logout.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/MobileDrawerMenu.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Shared/Navbar/MobileDrawerMenu.tsx Outdated Show resolved Hide resolved
sasicodes and others added 2 commits January 12, 2023 19:24
@sasicodes @bigint
Update apps/web/src/components/Shared/SwitchProfiles.tsx
4204e66 
Co-authored-by: bigint <69431456+bigint@users.noreply.github.com>
@sasicodes
chore: cleanup
264b47f
@vercel vercel bot temporarily deployed to Preview – api January 12, 2023 13:56 Inactive
@sasicodes sasicodes requested a review from bigint January 12, 2023 14:36
@bigint
Copy link
Member

bigint commented Jan 13, 2023

@sasicodes make sure to run yarn i18n:extract and push 🙇🏼

bigint
bigint approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint
Copy link
Member

bigint commented Jan 13, 2023

@sasicodes make sure to run yarn i18n:extract and push 🙇🏼

I'll do this in another PR 🚀

@bigint bigint merged commit dc232c8 into main Jan 13, 2023
@bigint bigint deleted the T-1444/implement-drawer-in-mobile-view-for-user-profile-menu branch January 13, 2023 03:55
sasicodes added a commit that referenced this pull request Jan 16, 2023
@sasicodes @bigint @harish-sethuraman
feat: mobile menu drawer (#1547)
6d6f298 
Co-authored-by: bigint <69431456+bigint@users.noreply.github.com>
Co-authored-by: Strek <ssharishkumar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harish-sethuraman harish-sethuraman harish-sethuraman left review comments

@bigint bigint bigint approved these changes

Assignees

@sasicodes sasicodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sasicodes @bigint @harish-sethuraman