Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "You can't reply to this post" not being visible in dark mode #1563

Merged
merged 3 commits into from Jan 9, 2023

Conversation

kyrers
Copy link
Contributor

@kyrers kyrers commented Jan 7, 2023

What does this PR do?

Hopefully, this will fix the "You can't reply to this post" text not being visible in dark mode according to your style guidelines and design choices.

I tested in light mode as well, and it is still visible with this change.

Fixes #1562

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • [X ] Enhancement (non-breaking small changes to existing functionality)

How should this be tested?

To make sure the issue exists, open a gated post in dark mode and verify that you can't see the "You can't reply to this post" text. Then, do the same with this PR applied and you should now be able to see the text in a greyish color.

@kyrers kyrers requested a review from bigint as a code owner January 7, 2023 18:43
@height
Copy link

height bot commented Jan 7, 2023

This pull request has been linked to 1 task:

  • T-2460 Fix "You can't reply to this post" not being visible in dark mode (unlink task)

💡Tip: Add "Close T-2460" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@vercel
Copy link

vercel bot commented Jan 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Jan 8, 2023 at 7:21PM (UTC)
web ✅ Ready (Inspect) Visit Preview Jan 8, 2023 at 7:21PM (UTC)

@vercel vercel bot temporarily deployed to Preview – api January 7, 2023 18:45 Inactive
@bigint
Copy link
Member

bigint commented Jan 8, 2023

Link T-2460

@vercel vercel bot temporarily deployed to Preview – api January 8, 2023 19:21 Inactive
@bigint bigint changed the title Fix "You can't reply to this post" not being visible in dark mode fix: "You can't reply to this post" not being visible in dark mode Jan 9, 2023
@bigint bigint disabled auto-merge January 9, 2023 04:42
@bigint bigint merged commit 44498d1 into heyxyz:main Jan 9, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 9, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Lenster Contributor:

GitPOAP: 2023 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

sasicodes pushed a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't see "you can't reply to this post" in dark mode
3 participants