Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nft picker added virtuoso grid #3760

Merged
merged 11 commits into from
Sep 14, 2023
Merged

feat: nft picker added virtuoso grid #3760

merged 11 commits into from
Sep 14, 2023

Conversation

bhavya2611
Copy link
Contributor

@bhavya2611 bhavya2611 commented Sep 12, 2023

What does this PR do?

🤖 Generated by Copilot at 9a302dc

This pull request enhances the user interface and performance of the NFT gallery and avatar features. It applies consistent styling and padding to the modal components, uses virtualized rendering and placeholders for the NFT grid, and fixes a bug with duplicate NFTs. It also adds a prop to the Card component to force rounded corners.

Related issues

Fixes #3574
Fixes ENG-23

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Emoji

🚀

@bhavya2611 bhavya2611 self-assigned this Sep 12, 2023
@height
Copy link

height bot commented Sep 12, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Sep 14, 2023 5:49am
web ✅ Ready (Inspect) Visit Preview Sep 14, 2023 5:49am

@vercel vercel bot temporarily deployed to Preview – prerender September 12, 2023 13:43 Inactive
@linear
Copy link

linear bot commented Sep 13, 2023

ENG-23

@bigint
Copy link
Member

bigint commented Sep 13, 2023

Screen.Recording.2023-09-13.at.9.16.34.PM.mov

@bhavya2611 shimmer got messed up 🙈

@vercel vercel bot temporarily deployed to Preview – prerender September 14, 2023 05:49 Inactive
@bigint bigint merged commit 8d5f7a9 into main Sep 14, 2023
7 of 8 checks passed
@bigint bigint deleted the feat/nft-virtuoso branch September 14, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENG-23] Migrate NFT picker to virtuosa grid
2 participants