Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content is not displayed if it's equal to 0. #26

Closed
alifshits opened this issue Sep 9, 2019 · 2 comments
Closed

Content is not displayed if it's equal to 0. #26

alifshits opened this issue Sep 9, 2019 · 2 comments
Assignees
Labels

Comments

@alifshits
Copy link

alifshits commented Sep 9, 2019

Hello!

If you bind ellipsis-content to an integer property which has value equal to 0, it won't be displayed.
Here is a stackblitz reproducing it: https://stackblitz.com/edit/angular-1smu3f-znwynp?file=app/ellipsis-example.ts

I believe the issue is here:


if (0) -> false

The issue wouldn't happen if ellipsis directive made unconditional toString call for ellipsisContent property.

What do you think?

Thanks.

@lentschi lentschi added the bug label Sep 9, 2019
@lentschi lentschi self-assigned this Sep 9, 2019
@lentschi
Copy link
Owner

lentschi commented Sep 9, 2019

@alexander8 You're right - thanks for reporting this in such detail!

Fixed in ngx-ellipsis@2.0.7.

@alifshits
Copy link
Author

Thank you, @lentschi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants