Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force MusicianComm channel in last position #41

Closed
LenweSaralonde opened this issue Apr 17, 2020 · 1 comment
Closed

Force MusicianComm channel in last position #41

LenweSaralonde opened this issue Apr 17, 2020 · 1 comment
Assignees
@LenweSaralonde
Labels
bug Something isn't working
Projects
Musician Musician
Milestone
1.6.0.4

Comments

@LenweSaralonde
Copy link
Owner

Sometimes regular General / Trade / LocalDefense take too much time to be joint and MusicianComm gets in first position.

image

Solution: Reorder channels every time the channel list is changed to force MusicianComm at the last position
@LenweSaralonde LenweSaralonde added the bug Something isn't working label Apr 17, 2020
@LenweSaralonde LenweSaralonde added this to To do in Musician via automation Apr 17, 2020
@LenweSaralonde LenweSaralonde added this to the 1.6.0.0 milestone Apr 17, 2020
@LenweSaralonde LenweSaralonde changed the title Force MusicianComm channel at last position Force MusicianComm channel in last position May 5, 2020
@LenweSaralonde LenweSaralonde moved this from To do to In progress in Musician May 5, 2020
LenweSaralonde added a commit that referenced this issue May 5, 2020
@LenweSaralonde
Force MusicianComm channel in last position #41
9345006
@LenweSaralonde LenweSaralonde self-assigned this May 5, 2020
@LenweSaralonde LenweSaralonde moved this from In progress to Done in Musician May 5, 2020
LenweSaralonde added a commit that referenced this issue May 12, 2020
@LenweSaralonde
Force MusicianComm channel in last position #41
b7377f3
@LenweSaralonde LenweSaralonde moved this from Done to Released in Musician May 13, 2020
Musician automation moved this from Released to Done May 13, 2020
@LenweSaralonde LenweSaralonde moved this from Done to Released in Musician May 13, 2020
@LenweSaralonde
Copy link
Owner Author

The CHAT_MSG_CHANNEL_NOTICE event is not always triggered when joining the standard General, Trade and Local Defense channels so in rare occasions, the channels are not reordered at login.

The channels are now also reordered on CHANNEL_UI_UPDATE which is properly triggered every time a new channel is joined.

Fixed in a9e4d2e (retail) and 8655a0b (classic)

Musician automation moved this from Released to In progress Jul 15, 2020
@LenweSaralonde LenweSaralonde modified the milestones: 1.6.0.0, 1.6.0.4 Jul 15, 2020
@LenweSaralonde LenweSaralonde moved this from In progress to Done in Musician Jul 15, 2020
@LenweSaralonde LenweSaralonde moved this from Done to Released in Musician Jul 15, 2020
Musician automation moved this from Released to Done Jul 15, 2020
@LenweSaralonde LenweSaralonde moved this from Done to Released in Musician Jul 23, 2020
@LenweSaralonde LenweSaralonde added this to Done in Musician Jun 3, 2021
@LenweSaralonde LenweSaralonde moved this from Done to Released in Musician Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LenweSaralonde LenweSaralonde

Labels
bug Something isn't working
Projects
No open projects
Musician
Released
Musician
Released
Milestone
1.6.0.4
Development

No branches or pull requests
1 participant
@LenweSaralonde