Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make URLs selectable #85

Closed
LenweSaralonde opened this issue Aug 29, 2022 · 0 comments
Closed

[Feature] Make URLs selectable #85

LenweSaralonde opened this issue Aug 29, 2022 · 0 comments
Assignees
@LenweSaralonde
Labels
backlog Idea not planned for development enhancement New feature or request
Milestone
1.9.1.1

Comments

@LenweSaralonde
Copy link
Owner

LenweSaralonde commented Aug 29, 2022 •
edited
Loading

Overview

Several URLs are present in the UI (Official website, Discord, donation page...) but are not interactive. The user needs to manually type them character by character in their browser address bar.

URLs should be handled as hyperlinks that can be easily copied into the browser address bar.

Implementation

  • Turn all text URLs into clickable hyperlinks.
  • Show the URLs between brackets to let the user know they're clickable.
  • Clicking a URL hyperlink opens a read-only EditBox with the exact same font and color over it. The text is focused and selected. A tooltip shows up with the message "Press Ctrl+C to copy".
  • The EditBox and the tooltip are dismissed when Ctrl+C is registered, Escape is pressed or the focus is lost.
  • On MacOS, "Ctrl" is replaced by "⌘".

Additional context

No response
@LenweSaralonde LenweSaralonde added enhancement New feature or request backlog Idea not planned for development labels Aug 29, 2022
@LenweSaralonde LenweSaralonde mentioned this issue Aug 29, 2022
Open
@LenweSaralonde LenweSaralonde self-assigned this Aug 29, 2022
LenweSaralonde added a commit that referenced this issue Aug 29, 2022
@LenweSaralonde
Make URLs selectable #85
66fc526
LenweSaralonde added a commit that referenced this issue Aug 29, 2022
@LenweSaralonde
Added symbol for the Mac Cmd key #85
9f00ef1 
Adjusted tooltip coloring
Fixed Cmd key release
LenweSaralonde added a commit that referenced this issue Aug 29, 2022
@LenweSaralonde
Moved URL tooltip to top to avoid the cursor #85
08db823
LenweSaralonde added a commit that referenced this issue Aug 30, 2022
@LenweSaralonde
Resized cmd symbol texture to 64x64 #85
0024959
LenweSaralonde added a commit that referenced this issue Aug 30, 2022
@LenweSaralonde
Added click sound on copy #85
3462756
LenweSaralonde added a commit that referenced this issue Aug 30, 2022
@LenweSaralonde
Rewrote Ctrl/Cmd keys support in URL selector #85
d0b89e7
LenweSaralonde added a commit that referenced this issue Aug 30, 2022
@LenweSaralonde
Fixed font size side effect with GameTooltip #85
2aa99a3
@LenweSaralonde LenweSaralonde added this to the 1.9.1.1 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LenweSaralonde LenweSaralonde

Labels
backlog Idea not planned for development enhancement New feature or request
Projects
None yet
Milestone
1.9.1.1
Development

No branches or pull requests
1 participant
@LenweSaralonde