Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Consistently being asked for a password for MusicianComm #86

Closed
NayteDogg opened this issue Sep 7, 2022 · 1 comment
Closed
Assignees
Labels
backlog Idea not planned for development bug Something isn't working
Milestone

Comments

@NayteDogg
Copy link

Description

In the Wotlk Classic, players are getting frequently spammed with a dialog box that says to enter a password for MusicianComm. No matter what they do, enter a password or not, they continue to get spammed with this dialog box.

Reproduction steps

  1. Log in to Wotlk classic servers with addon
  2. Just wait around

Actual behavior

A password Dialog box appears and is spammy

Expected behavior

Dont think players should be needing to enter a password for anything.

Screenshots

Screenshot 2022-09-06 225728

World of Warcraft flavor

Wrath of the Lich King Classic

World of Warcraft version

3.4.0 (45435)

Add-on version

1.9.1.1

Have you tried disabling all your other add-ons to ensure only this add-on causes the issue?

Yes

Additional context

No response

@NayteDogg NayteDogg added backlog Idea not planned for development bug Something isn't working labels Sep 7, 2022
@LenweSaralonde
Copy link
Owner

LenweSaralonde commented Sep 7, 2022

Typo in onChannelFailed() function in Musician.Comm , WRONG_PASSWORD is nil and should be within a string.

In case of incorrect password:

  • Retry to join with no password (it may have been removed accidentally by the current channel owner)
  • Increase retry delay to 10 minutes when passworded on Retail
  • Give up on Classic since the Comm channel is not mandatory on Classic.
  • Attempt to hide the password popup if the joining process was not initiated manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Idea not planned for development bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants