Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageScore fields can be null #10

Closed
Rexios80 opened this issue Aug 2, 2021 · 6 comments
Closed

PackageScore fields can be null #10

Rexios80 opened this issue Aug 2, 2021 · 6 comments

Comments

@Rexios80
Copy link
Contributor

Rexios80 commented Aug 2, 2021

If a package was recently updated, some of the information in PackageScore can be null. For example: grantedPubPoints and popularityScore. These should be handled by the client.

@leoafarias
Copy link
Owner

@Rexios80 In this particular case I believe the correct behavior would be just to have those params nullable. The other option is to set a default value, but not sure if that would be the correct apporoach.

@Rexios80
Copy link
Contributor Author

Rexios80 commented Aug 3, 2021

Nullable fields makes the most sense to me

@leoafarias
Copy link
Owner

@Rexios80 would you like to do a PR for this? If not I will try to get to it over the weekend

@Rexios80
Copy link
Contributor Author

Rexios80 commented Aug 3, 2021

I will if I have time. I'm going to have to do some testing to figure out what fields are nullable unless you happen to already know.

@leoafarias
Copy link
Owner

@Rexios80 if you can double check would be great.

@Rexios80
Copy link
Contributor Author

Rexios80 commented Aug 3, 2021

#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants